-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix Asyncify.handleAsync conflict with PROXY_SYNC_ASYNC #26513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9652,6 +9652,15 @@ def test_poll_blocking_asyncify(self): | |
| self.skipTest('test requires setTimeout which is not supported under v8') | ||
| self.do_runf('core/test_poll_blocking_asyncify.c', 'done\n') | ||
|
|
||
| @with_asyncify_and_jspi | ||
| def test_poll_blocking_asyncify_pthread(self): | ||
| # require_pthreads can fail when require_jspi selects d8 (which doesn't | ||
| # support pthreads). Convert to skip since the test needs both. | ||
| if not any(engine_is_node(e) or engine_is_bun(e) for e in self.js_engines): | ||
| self.skipTest('no JS engine capable of running pthreads') | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't love having these extra 4 lines here. Especially with the automatic skip thing (we try not to auto-skip stuff in general, but force folks to opt into skipping this kind of thing) It seems like there is some kind of bad interaction here between |
||
| self.require_pthreads() | ||
| self.do_runf('core/test_poll_blocking.c', 'done\n', cflags=['-sPROXY_TO_PTHREAD', '-sEXIT_RUNTIME']) | ||
|
|
||
| @parameterized({ | ||
| '': ([],), | ||
| 'pthread': (['-pthread'],), | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.