fix: Remove ember-responsive#1676
Merged
SergeAstapov merged 1 commit intoember-learn:mainfrom May 3, 2025
Merged
Conversation
Contributor
MichalBryxi
commented
May 2, 2025
MichalBryxi
commented
- The package insists on having @ember/string v3
- It does not do too much
- The package insists on having @ember/string v3 - It does not do too much
MichalBryxi
commented
May 2, 2025
| {{if this.media.isMobile | ||
| (if this.isShowingMenu "docs-opacity-100 docs-bg-white" "docs-opacity-0 docs-pointer-events-none") | ||
| }} | ||
| {{if this.isShowingMenu "docs-opacity-100 docs-bg-white md:docs-opacity-0" "docs-opacity-0 md:docs-opacity-100 docs-pointer-events-none md:docs-pointer-events-auto"}} |
Contributor
Author
There was a problem hiding this comment.
I think the truthy part of this can be ommited as it won't be shown anyways as the button toggling isShowingMenu won't be there. But for a good measure I added the opacity styles anyway.
Contributor
Author
|
Ready for review @SergeAstapov |
SergeAstapov
reviewed
May 2, 2025
Contributor
Author
|
Fixed: #1675 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.