Skip to content

Extract rule: template-no-class-bindings#2459

Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-no-class-bindings
Mar 12, 2026
Merged

Extract rule: template-no-class-bindings#2459
NullVoxPopuli merged 1 commit intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-no-class-bindings

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

Split from #2371.

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-class-bindings branch from a66b169 to 5c3a913 Compare March 10, 2026 22:26
@johanrd
Copy link
Copy Markdown
Contributor

johanrd commented Mar 12, 2026

Review from Claude against ember-template-lint rule: no-class-bindings

Status: PASS ✅

Disallows classBinding/classNameBindings arguments.

  • Slightly stricter than original (also catches non-@ prefixed attrs on angle bracket components). Reasonable enhancement.
  • Good test coverage of all 4 forbidden patterns.

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-class-bindings branch from 5c3a913 to 4d27b16 Compare March 12, 2026 22:33
@NullVoxPopuli NullVoxPopuli merged commit 61f7b36 into ember-cli:master Mar 12, 2026
9 checks passed
@NullVoxPopuli NullVoxPopuli deleted the nvp/template-lint-extract-rule-template-no-class-bindings branch March 12, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants