Skip to content

Extract rule: template-no-forbidden-elements#2435

Merged
NullVoxPopuli merged 2 commits intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-no-forbidden-elements
Mar 13, 2026
Merged

Extract rule: template-no-forbidden-elements#2435
NullVoxPopuli merged 2 commits intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-no-forbidden-elements

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

Split from #2371.

@NullVoxPopuli NullVoxPopuli marked this pull request as draft February 27, 2026 22:41
@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-forbidden-elements branch from 92d4939 to 7765ff2 Compare March 1, 2026 00:03
@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-forbidden-elements branch from 7765ff2 to 5df611c Compare March 10, 2026 22:28
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review March 10, 2026 22:31
@johanrd
Copy link
Copy Markdown
Contributor

johanrd commented Mar 12, 2026

Review from claude: comparing against ember-template-lint no-forbidden-elements

Missing object config form. The original accepts { forbidden: ['script', 'style'] } as configuration. The PR schema only allows boolean or string[]. Users migrating from ember-template-lint with the
object form would get a schema validation error. Add it to the schema and handle it in config parsing.

head.hbs file exception — not applicable. This is an hbs-only concern, irrelevant for gjs/gts. The <meta> inside <head> element exception is correctly handled.

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-forbidden-elements branch from 5df611c to b63b79d Compare March 13, 2026 18:18
@NullVoxPopuli NullVoxPopuli merged commit 292c12d into ember-cli:master Mar 13, 2026
11 checks passed
@NullVoxPopuli NullVoxPopuli deleted the nvp/template-lint-extract-rule-template-no-forbidden-elements branch March 13, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants