Conversation
added 4 commits
March 10, 2026 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Multi-instance REMS support (
__init__.py,rems_oidc_handler.py,multiple_rems_handler.py)MultipleRemsAccessHandler— routes REMS API calls to the correct instance (REMS_INSTANCESconfig) based ondataset.instance_idMultipleRemsOidcAccessHandler— same, but with OIDC-based access check (from tokenaccesses) on topget_access_handler()now auto-selects theMultiple*variant whenCONNECTED_INSTANCESis configured2. Multi-instance Daisy import (
daisy_connector.py,commands.py)DaisyConnectorgains aninstance_idparameter, which is stamped on each imported entity_build_separate_dataset()internal builder for pluginDatasetsubclasses (handlesisnanfloat values from metadata)description,deprecated,released_on,request_pdf_enabled) from the common builder — now comes entirely frommetadataJSONget_importer_connector()renamed toget_importer_connectors()→ now returns a list; CLIindex/deletecommands loop over all connectorsCONNECTED_INSTANCES→ creates oneDaisyConnectorper instance3. Multi-instance REMS export (
commands.py)exportCLI command now loops overCONNECTED_INSTANCES, filters entities byinstance_id, and exports each group to its own REMS connector4. Access caching on search (
web_controllers.py)update_users_accesses()— on every search page load, checks approved REMS access for the current user across all entities and syncsaccess_granted_usersfield in Solr (used for faceting/filtering)has_accessdict (per entity) passed to the templateaccess_granted_usersfacet is filtered to only show the current user's own count5. JSON export endpoint (
web_controllers.py)GET /e/<entity_name>/<entity_id>/export_json_entity— exports entity as a downloadable JSON file6. Config template (
settings.py.template)CONNECTED_INSTANCES,DAISY_INSTANCES, andREMS_INSTANCESconfig keys