Skip to content

More cleanup of older OTP versions#15170

Merged
sabiwara merged 4 commits intoelixir-lang:mainfrom
sabiwara:erlang-29-cleanup3
Mar 10, 2026
Merged

More cleanup of older OTP versions#15170
sabiwara merged 4 commits intoelixir-lang:mainfrom
sabiwara:erlang-29-cleanup3

Conversation

@sabiwara
Copy link
Contributor

I found some remaining items from #15164.

The last item 140595a is not directly related, but I noticed that the Mix intro required a less ancient version so I thought it might be good to use the same.

reason: {log_value(kind, value), __STACKTRACE__},
# TODO use Process.get_label/0 when we require Erlang/OTP 27+
process_label: Process.get(:"$process_label", :undefined)
process_label: :proc_lib.get_label(self())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went with raw :proc_lib since we don't want the nilification here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prolly worth a comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, done ✅ ed68114

reason: {log_value(kind, value), __STACKTRACE__},
# TODO use Process.get_label/0 when we require Erlang/OTP 27+
process_label: Process.get(:"$process_label", :undefined)
process_label: :proc_lib.get_label(self())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prolly worth a comment?

@sabiwara sabiwara merged commit 10902df into elixir-lang:main Mar 10, 2026
16 checks passed
@sabiwara sabiwara deleted the erlang-29-cleanup3 branch March 10, 2026 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants