Clarify nav-v2 styling port scope for #3256 and provide exact commits to cherry-pick#3275
Draft
Copilot wants to merge 7 commits into
Draft
Clarify nav-v2 styling port scope for #3256 and provide exact commits to cherry-pick#3275Copilot wants to merge 7 commits into
Copilot wants to merge 7 commits into
Conversation
Fix CI npm fmt:check on pages-nav-v2.ts and styles.css. Co-authored-by: Cursor <cursoragent@cursor.com>
Backports the YAML fill from demo/findability (PR #3268). Pure additions to config/navigation-v2.yml within the existing structure — no schema changes, no new directives. Closes most of the gap between v1 nav and the nav-v2 prototype. - Re-enable the commented Reference label and expand it: docs-content reference (top-level fanout), elasticsearch core/plugins/community- contributed, kibana, Cloud (cloud + cloud-on-k8s), Elasticsearch clients (java/js/dsl-js/.net/php/py/ruby/rs, eland, go-elasticsearch, curator), APM (k8s-attacher, aws-lambda, all agent libs), OpenTelemetry (opentelemetry root + motlp + edot-cloud-forwarder for AWS/Azure/GCP, edot-collector, all EDOT SDKs), ECS Logging (root + all per-language libs), beats, logstash, integration-docs, elasticsearch-hadoop, elastic-serverless-forwarder, ecs, search-ui, ecctl, plus aggregations/enrich-processor/query-languages/scripting-languages/ text-analysis. ~1,200 pages. - Wire children of 12 deploy-manage landings (security, users-roles, monitor, tools, remote-clusters, upgrade, cloud-organization, maintenance, api-keys, autoscaling, license, uninstall) under each existing `- group:` to preserve curated titles. ~370 pages. - Convert distributed-architecture leaf entries into groups with canonical children: clusters-nodes-shards (node-roles), shard-allocation-relocation-recovery (shard-allocation-awareness + index-level-shard-allocation w/ delaying-allocation-when-node-leaves), discovery-cluster-formation (6 children). - Convert production-guidance leaf entries into groups with their full canonical structure: Run Elasticsearch in production (Design for resilience [3 children], Scaling considerations, Performance optimizations [6 children]); Run Kibana in production (6 children). - Convert ingest-reference-architectures leaf into a group with the 16 canonical children grouped by architecture (Agent to Elasticsearch, Agent with Logstash, Agent with Kafka, Air-gapped, Logstash as input, Agent through a proxy). Set ingesting-data-for-elastic-solutions.md as the "Ingest by solution" group landing. Surface manage-data/ingest/tools.md alongside the existing API/upload entries. - Add Release notes top-level label with the per-product release-notes tree (Elasticsearch + clients + Hadoop, Kibana, Elastic Agent, Fleet Server, Logstash, Beats, Serverless, Cloud Hosted, Cloud Enterprise, Cloud on K8s, Observability with EDOT SDKs and APM agents, Security, ECS, ECCTL). - Add Troubleshoot top-level label as `- toc: docs-content://troubleshoot` (covers ~190 pages). Delete the dead Troubleshooting comment block whose entries are all already reachable via that toc. - Replace 57 `{{templated}}` substitution tokens (in titles AND group labels) with their literal expansions per docs-content/docset.yml:: features. The nav renderer does not expand `{{...}}` so leaving them caused literal `{{ece}}` etc. to render in the sidebar. Skipped (depends on features added in later layers of the stack): - Liam's Search and query rewrite (PR #3094, against this branch). - Products section (introduced in hub-pages). - island: entries (Logstash plugins/versioned plugins; needs nav-v2-sections). - Observability page additions on demo (slot under groups added in hub-pages stack). YAML valid. 173/173 navigation tests pass. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Ensure folder rows stay expanded on first re-activation click and introduce an explicit immediate-parent active marker while preserving full ancestor state styling. Co-authored-by: Cursor <cursoragent@cursor.com>
Align top-level label spacing and active-row visuals with the latest nav spec, and make the right-side On this page links/border keep the nav text color on hover. Co-authored-by: Cursor <cursoragent@cursor.com>
Switch sidebar utility links and the On this page heading container to the body font stack and normal weight to match the rest of the navigation typography. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # src/Elastic.Documentation.Site/Navigation/IsolatedBuildNavigationHtmlWriter.cs # src/Elastic.Documentation.Site/Navigation/NavigationViewModel.cs # src/Elastic.Documentation.Site/Navigation/_TocTree.cshtml # src/Elastic.Documentation.Site/Navigation/_TocTreeNav.cshtml
Copilot
AI
changed the title
[WIP] Prototype nav-v2: new IA with label sections, accordion sidebar
Clarify nav-v2 styling port scope for #3256 and provide exact commits to cherry-pick
May 8, 2026
Member
|
@copilot Target branch is wrong. It should be the one from the 3256 PR... |
Contributor
Author
You’re right — PR #3275 is currently based on Screenshot/preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/docs/2927/get-started |
theletterf
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follow-up addresses the request to port the “2927 styling improvements” into the
#3256line. The key outcome is confirming the requested styling work is already present on this branch and documenting the exact commits to apply downstream.Scope clarified
Porting guidance provided
#3256:d842694— folder click activation / parent statef035fad— sidebar spacing + active/TOC color tuning5defb05— TOC font/utility-link weight adjustments3b6428b— related nav wiring contextReviewer-facing verification artifact
# apply onto the target #3256 branch git cherry-pick d842694 f035fad 5defb05 3b6428b