Conversation
…pe_utils.cc tensorflow/dtensor/mlir/shape_utils.cc:76 uses unqualified cast<mlir::OpResult> which is ambiguous with Eigen::internal::cast under GCC. Use llvm::cast explicitly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the py-tensorflow Spack package to work around a GCC-only compilation failure in TensorFlow dtensor by explicitly qualifying an ambiguous cast<mlir::OpResult> call as llvm::cast.
Changes:
- Keeps the existing upstream patch for TensorFlow
@2.15:2.19. - Adds a GCC-conditional source edit for TensorFlow
@2.20:to qualifycast<mlir::OpResult>asllvm::cast<mlir::OpResult>.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…pansion.cc Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
wdconinc
changed the title
…pansion.cc GCC cannot resolve unqualified isa<mlir::TF::ResourceType> at line 224 without the llvm:: namespace prefix. Add a filter_file to qualify it, analogous to the existing cast<> fixes in the same method. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
Contributor
Author
|
(Will upstream in due course) |
veprbl
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
tensorflow/dtensor/mlir/shape_utils.cc:76uses unqualifiedcast<mlir::OpResult>which is ambiguous withEigen::internal::castunder GCC. Same intensorflow/dtensor/mlir/spmd_expansion.cc:191. This PR usesllvm::castexplicitly.