Skip to content

feat: only link roots into default view #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wdconinc wants to merge 5 commits into
base: master
Choose a base branch
from
+5 −0
Open

feat: only link roots into default view #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8877d0c
feat: only link roots into default view
wdconinc Mar 23, 2026
558da91
fix: eic_tf: add root as root
wdconinc Mar 23, 2026
a7e8145
fix: rm py-pip from view exclusions
wdconinc Mar 26, 2026
2922d26
fix: add vdt to roots for eic_xl
wdconinc Apr 19, 2026
f1bc636
fix: ensure vdt in view for eic_ci
wdconinc Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions spack-environment/ci/spack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,5 @@ spack:
- root
- snakemake
- spdlog
- vdt # ensure headers in view for ROOT
- xrootd
1 change: 1 addition & 0 deletions spack-environment/tf/spack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,5 @@ spack:
- py-toml
- py-uproot
- py-vector
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This environment now explicitly adds root as a view root, but unlike xl/ci it doesn’t also add vdt (which those envs add to keep ROOT’s headers usable under link: roots). If ROOT’s public headers include VDT headers, compilation against ROOT via the view will fail here. Either add vdt as a root here too, or add a brief note explaining why TF doesn’t require it.

Suggested change
- py-vector
- py-vector
- vdt

Copilot uses AI. Check for mistakes.
- root
Comment thread
wdconinc marked this conversation as resolved.
- xrootd
2 changes: 2 additions & 0 deletions spack-environment/view.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ view:
root: /opt/local
exclude:
- epic
- py-urllib3@1
link: roots
link_type: symlink
Comment thread
wdconinc marked this conversation as resolved.
detectors:
root: /opt/detector
Expand Down
1 change: 1 addition & 0 deletions spack-environment/xl/spack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,5 +131,6 @@ spack:
- stow
- strace
- valgrind
- vdt # ensure headers in view for ROOT
Copy link

Copilot AI Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vdt is being added as an explicit root here to keep its headers present in the view for ROOT under link: roots, but other environments that also include root (e.g. cuda/, prod/, cvmfs/, jl/, tf/, ci_without_acts/) still don’t list vdt. If ROOT headers transitively include VDT headers, those envs will still have a broken /opt/local view for compilation. Consider adding vdt consistently wherever root is a root spec, or document why it’s only needed in xl/ci.

Copilot uses AI. Check for mistakes.
- xrootd
- xeyes
Loading