refactor(providers-evm-rpc): use structured tracing fields for block fetch progress logs#2007
Open
shiyasmohd wants to merge 1 commit intomainfrom
Open
refactor(providers-evm-rpc): use structured tracing fields for block fetch progress logs#2007shiyasmohd wants to merge 1 commit intomainfrom
shiyasmohd wants to merge 1 commit intomainfrom
Conversation
LNSD
reviewed
Mar 23, 2026
Contributor
LNSD
left a comment
LNSD
left a comment
There was a problem hiding this comment.
Please, check my comments 🙂
Comment on lines
429
to
436
| tracing::info!( | ||
| "Progress {}/{} ({}%) blocks (with {} txns) in {}ms", | ||
| "Progress {}/{} ({:.2}%) blocks (with {} txns) in {}ms", | ||
| blocks_completed, | ||
| total_blocks_to_stream, | ||
| (blocks_completed as f32 / total_blocks_to_stream as f32) * 100.0, | ||
| txns_completed, | ||
| start.elapsed().as_millis() | ||
| ); |
Contributor
There was a problem hiding this comment.
We should emit this data as trace/log fields, not as formatted strings. That would allow us to build dashboards and filter based on fields.
shiyasmohd
force-pushed
the
shiyasmohd/format-progress
branch
from
0426042 to
c7d68a4
Compare
shiyasmohd
changed the title
…fetch progress logs
shiyasmohd
force-pushed
the
shiyasmohd/format-progress
branch
from
c7d68a4 to
2546b26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.