Skip to content

Fix element count calculation issue #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fh-ms merged 2 commits into from
Mar 30, 2026
Merged

Fix element count calculation issue #252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dbc485
Fix inaccurate element count calculation
fh-ms Mar 30, 2026
9459e83
Improve error message for inconsistent element count detection
fh-ms Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion persistence/binary/src/main/java/org/eclipse/serializer/persistence/binary/types/Binary.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2096,9 +2096,10 @@ private static void validatePostIterationState(
// (19.03.2019 TM)NOTE: added "|| iterator.hasNext()" check
if(address != elementsBinaryBound || iterator.hasNext())
{
final long iteratedCount = elementCount - (elementsBinaryBound - address) / entryLength;
throw new BinaryPersistenceException(
"Inconsistent element count: specified " + elementCount
+ " vs. iterated " + elementsBinaryBound / entryLength
+ " vs. iterated " + (iterator.hasNext() ? "more than " + iteratedCount : iteratedCount)
);
}
}
Expand Down
Loading