Skip to content

chore: Add null check to the Bitbucket Server URL parser#983

Merged
vinokurig merged 1 commit intomainfrom
che-23766
Mar 30, 2026
Merged

chore: Add null check to the Bitbucket Server URL parser#983
vinokurig merged 1 commit intomainfrom
che-23766

Conversation

@vinokurig
Copy link
Copy Markdown
Contributor

@vinokurig vinokurig commented Mar 24, 2026

What does this PR do?

Fix the NullPointerException when starting a workspace from a BItbucket Server repository URL copied from browser's address bar.

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes eclipse-che/che#23766

How to test this PR?

  1. Deploy Che from the pull request image: quay.io/eclipse/che-server:pr-983
  2. Configure Bitbucket Server oauth
  3. Start a workspace from the Bitbucket Server repository URL copied from browser's address bar, e.g. https://<bitbucket server host>/users/<user>/repos/<repository name>/browse. Important: the default branch must be used, if a non default branch is selected the url will contain an additional query parameter (?at=<branch reference>).
  4. See: workspace starts without any errors.

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@github-actions
Copy link
Copy Markdown

Docker image build succeeded: quay.io/eclipse/che-server:pr-983

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/cheServer/deployment", "value": {containers: [{image: "quay.io/eclipse/che-server:pr-983", name: che}]}}]"

@vinokurig
Copy link
Copy Markdown
Contributor Author

/retest

@artaleks9
Copy link
Copy Markdown
Contributor

Verified on Eclipse Che-next deployed on OCP 4.20 with quay.io/eclipse/che-server:pr-983

The functionality works properly

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: artaleks9, tolusha, vinokurig

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit f358b50 into main Mar 30, 2026
29 checks passed
@vinokurig vinokurig deleted the che-23766 branch March 30, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NPE parsing Bitbucket Server browse URL without ?at=

3 participants