Skip to content

Improved limits for certain parameters#304

Open
rozyczko wants to merge 1 commit intodevelopfrom
better_limits
Open

Improved limits for certain parameters#304
rozyczko wants to merge 1 commit intodevelopfrom
better_limits

Conversation

@rozyczko
Copy link
Copy Markdown
Member

@rozyczko rozyczko commented Mar 31, 2026

The results of the discussion with Jos and Grace about the parameter limits. Using [0,inf] or [-inf,inf] is not a good idea since the fitting (if started too far away from the right solution) can lead to non-physical minima.
The agreed on initial values should be as follows:

  • thickness/roughness from 50% to 200% of current/default value
  • sld between -1.0 and 10.0
  • scale between 0 and 1.0

These of course only apply to values not set explicitly by the user.

Addresses easyscience/EasyReflectometryApp#289

Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@rozyczko rozyczko assigned rozyczko and unassigned rozyczko Mar 31, 2026
@rozyczko rozyczko added [scope] enhancement Adds/improves features (major.MINOR.patch) [priority] high Should be prioritized soon enhancement labels Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement [priority] high Should be prioritized soon [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant