Conversation
…files when releasing new version of Cratey-Validator
douglowe
left a comment
There was a problem hiding this comment.
I've added a couple of comments below. I'd like us to make this build specific to five-safes rocrates, so the naming should reflect this. Also we need to make sure to copy across a tagged release of our five-safes profile, so that we can in future say which exact version of the profile this will test against.
…file version is accessible through a label () or as an environment variable from inside the Docker image ().
douglowe
left a comment
There was a problem hiding this comment.
I've added a note regarding changing the location that the profile is extracted to.
On a broader compatibility note, I've tested building this container, and found that the five safes rocrate profile isn't compatible with the rocrate validator version in this container.
When I try to list the profiles I get the following error:
│ /usr/local/lib/python3.11/site-packages/rocrate_validator/profiles/five-safes-crate/must/15_meta │
│ data_file.py:17 in <module> │
│ │
│ 14 │
│ 15 import re │
│ 16 │
│ ❱ 17 import rocrate_validator.log as logging │
│ 18 from rocrate_validator.models import Severity, ValidationContext │
│ 19 from rocrate_validator.requirements.python import PyFunctionCheck, check, requirement │
│ 20 │
╰──────────────────────────────────────────────────────────────────────────────────────────────────╯
ModuleNotFoundError: No module named 'rocrate_validator.log'
Do we need to import rocrate_validator.log in this file? Is this an error that has already been fixed? If so we should make a new release which includes the fix.
Lline 17 of
I will create a new release of the crate-validator |
… now the five-safes profile imported contains the fix of the log import.
douglowe
left a comment
There was a problem hiding this comment.
Looks good to me now. Thanks for getting this sorted!
Closes #135
Added dockerfile and workflow to build Docker image with baked-in profiles when releasing new version of Cratey-Validator.