Fix DataContractSerializer nullable struct initialization cache lookup#128506
Draft
Copilot wants to merge 2 commits into
Draft
Fix DataContractSerializer nullable struct initialization cache lookup#128506Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/642c45d2-e603-4c5f-a2be-9a512be7b7a0 Co-authored-by: StephenMolloy <19562826+StephenMolloy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix DataContractSerializer bug with nullable structs in .NET 8
Fix DataContractSerializer nullable struct initialization cache lookup
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DataContractSerializerregressed in .NET 8+ when deserializingNullable<T>for[DataContract]structs that had not been initialized in the cache path yet, causingSerializationException(DataContract cache overflow).The initialization lookup loop compared against the wrong cache slot, so valid contracts were not found.
Runtime fix (
System.Private.DataContractSerialization)Corrected
DataContract.GetIdForInitialization(ClassDataContract)to scan cache entries by loop index instead of repeatedly reading the originally computed id.Regression coverage (
System.Runtime.Serialization.Xmltests)Added a focused test that round-trips a nullable root
[DataContract]struct and verifies successful deserialization without requiring prior serialization of the non-nullable struct type.