Skip to content

[XmlSerializer] Avoid IList/Array.GetValue path for array item serialization in reflection writer #128504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −2
Draft

[XmlSerializer] Avoid IList/Array.GetValue path for array item serialization in reflection writer #128504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b232bfc
Initial plan
Copilot May 22, 2026
5c38aaf
Optimize ReflectionXmlSerializationWriter array item iteration
Copilot May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions ...aries/System.Private.Xml/src/System/Xml/Serialization/ReflectionXmlSerializationWriter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,30 @@ private void WriteArray(object o, object? choiceSource, ElementAccessor[] elemen

private void WriteArrayItems(ElementAccessor[] elements, TextAccessor? text, ChoiceIdentifierAccessor? choice, object o, object? choiceSources)
{
Array? choiceArray = choiceSources as Array;

if (o is Array array)
{
IEnumerator e = array.GetEnumerator();
int c = 0;
while (e.MoveNext())
{
object ai = e.Current;
object? choiceSource = choiceArray?.GetValue(c++);
WriteElements(ai, choiceSource, elements, text, choice, true, true);
}

return;
}

var arr = o as IList;

if (arr != null)
{
for (int i = 0; i < arr.Count; i++)
{
object? ai = arr[i];
var choiceSource = ((Array?)choiceSources)?.GetValue(i);
object? choiceSource = choiceArray?.GetValue(i);
WriteElements(ai, choiceSource, elements, text, choice, true, true);
}
}
Expand All @@ -175,7 +191,7 @@ private void WriteArrayItems(ElementAccessor[] elements, TextAccessor? text, Cho
while (e.MoveNext())
{
object ai = e.Current;
var choiceSource = ((Array?)choiceSources)?.GetValue(c++);
object? choiceSource = choiceArray?.GetValue(c++);
WriteElements(ai, choiceSource, elements, text, choice, true, true);
}
}
Expand Down