Restore E_NOTIMPL fallback in DacDbiInterfaceImpl::GetContext#128499
Open
tommcdon wants to merge 1 commit into
Open
Restore E_NOTIMPL fallback in DacDbiInterfaceImpl::GetContext#128499tommcdon wants to merge 1 commit into
tommcdon wants to merge 1 commit into
Conversation
On platforms where ICorDebugDataTarget::GetThreadContext returns E_NOTIMPL, restore the fallback that walks the thread's Frame chain to reconstruct a register context from REGDISPLAY. This is needed for managed debugging stack walks on non-Windows platforms. The fallback was inadvertently removed in 5391e9e. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Member
Author
|
cc @janvorli |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CoreCLR’s DAC/DBI implementation of DacDbiInterfaceImpl::GetContext to handle data targets that return E_NOTIMPL from ICorDebugDataTarget::GetThreadContext by falling back to reconstructing a usable register context from the thread’s frame chain.
Changes:
- Stop throwing on
GetThreadContextreturningE_NOTIMPL; instead, walkThread’sFramechain and useUpdateRegDisplay+UpdateContextFromRegDispto synthesize a context suitable for managed stack walking. - Add a
FEATURE_INTERPRETERfast-path to synthesize context fromInterpreterFrameviaSetContextToInterpMethodContextFrame. - Zero the output context when no suitable managed frame context can be reconstructed.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On platforms where ICorDebugDataTarget::GetThreadContext returns E_NOTIMPL, restore the fallback that walks the thread's Frame chain to reconstruct a register context from REGDISPLAY. This is needed for managed debugging stack walks on non-Windows platforms.
The fallback was removed in 5391e9e.
Found using internal Visual Studio testing