Add use with trusted files remark to FileVersionInfo.GetVersionInfo#12641
Add use with trusted files remark to FileVersionInfo.GetVersionInfo#12641steveisok wants to merge 2 commits into
Conversation
|
@steveisok - This PR edits one or more files whose 'source of truth' for documentation is not in this repo. Please make documentation updates in the /// comments in the dotnet/runtime repo (or dotnet/extensions repo) instead. |
There was a problem hiding this comment.
Pull request overview
This PR updates the API reference documentation for System.Diagnostics.FileVersionInfo.GetVersionInfo(String) to add a security-focused caution about using the API only with trusted files.
Changes:
- Added a new “Remarks” section under
GetVersionInfowith a[!CAUTION]admonition about trusted files and malformed/malicious inputs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This library's source of truth is in the ///. Can you add the note there instead?
|
@gewarren I'm not sure where you are suggesting. Can you please clarify? |
|
@steveisok Can you add a <remarks> tag here. (Not sure what happened to the code example during the backport to the runtime repo...) |
I see - I can push this change in runtime. |
Summary
Add a small remark about using trusted files when calling FileVersionInfo.GetVersionInfo.