Add System.Uri and System.UriBuilder threat model references to API docs#12418
Open
Add System.Uri and System.UriBuilder threat model references to API docs#12418
Conversation
Co-authored-by: MihaZupan <25307628+MihaZupan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
MihaZupan
March 18, 2026 20:14
View session
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the API reference documentation for System.Uri and System.UriBuilder to include links to newly published threat model documents, so readers can find design and security considerations directly from the API pages.
Changes:
- Expanded
<remarks>content to include links to theSystem.UriandSystem.UriBuilderthreat model documents. - Added
<related type="ExternalDocumentation">entries pointing to the same threat model documents.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| xml/System/Uri.xml | Converts remarks to markdown and adds threat model links plus external related links. |
| xml/System/UriBuilder.xml | Adds threat model links to remarks and adds external related links. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet/runtime#124273 published threat model documents for
System.UriandSystem.UriBuilder. These should be referenced from the API reference pages, complementing the conceptual docs changes in dotnet/docs#52465.Changes
xml/System/Uri.xml— Expanded remarks to include threat model links; added<related type="ExternalDocumentation">entries for both documentsxml/System/UriBuilder.xml— Added threat model links to existing remarks; added<related type="ExternalDocumentation">entriesBoth files link to:
System.Urithreat modelSystem.UriBuilderthreat model