Use shared AdbRunner from android-tools for device listing

[rmarinho]

Summary

Delegates the adb devices -l parsing, description building, and device/emulator merging logic from the GetAvailableAndroidDevices MSBuild task to the shared AdbRunner in Xamarin.Android.Tools.AndroidSdk (via the external/xamarin-android-tools submodule).

This removes ~200 lines of duplicated parsing/formatting/merging code from dotnet/android and consolidates it in the shared android-tools library where it can be reused by other consumers (e.g., the MAUI DevTools CLI).

Changes

• Submodule update: external/xamarin-android-tools → feature/adb-runner branch (82de0a1)
  • Includes TCP console fallback for AVD name resolution (fixes macOS issue where adb emu avd name returns empty)
  • Bare catch fix with exception logging
  • Regex fix for explicit adb states and tab support
  • Nullable reference type fixes
• GetAvailableAndroidDevices.cs: Rewritten to delegate to AdbRunner.ParseAdbDevicesOutput(IEnumerable<string>), AdbRunner.BuildDeviceDescription, and AdbRunner.MergeDevicesAndEmulators instead of having its own parsing logic. Added ConvertToTaskItems to bridge AdbDeviceInfo → ITaskItem.
• GetAvailableAndroidDevicesTests.cs: Updated to use AdbRunner/AdbDeviceInfo directly instead of reflection. All tests preserved with equivalent coverage.

Key improvements from updated submodule

The updated AdbRunner includes a TCP console fallback for AVD name resolution. On macOS, adb -s emulator-XXXX emu avd name often returns exit code 0 but with empty output, causing:

1. Running emulators to show as "sdk gphone64 arm64" instead of their AVD name
2. MergeDevicesAndEmulators unable to match running emulators with AVD definitions (potential duplicates)

The fallback connects to the emulator console port and queries avd name directly, which reliably returns the correct name.

Review feedback addressed

• ParseAdbDevicesOutput accepts IEnumerable<string> to avoid string.Join allocation — callers pass List<string> directly
• BuildDeviceDescription and MergeDevicesAndEmulators accept optional Action<TraceLevel, string> logger callback following existing CreateTaskLogger pattern, restoring MSBuild debug diagnostics
• GetAvailableAndroidDevices still extends AndroidAdb (needs base.RunTask(), ToolPath/ToolExe, LogEventsFromTextOutput)

Dependencies

• Depends on dotnet/android-tools#283 being merged first
• Once android-tools PR Bump mono to mono-4.8.0-branch commit 8864f4c and install Mono.Btls.Interface #283 is merged, this PR's submodule pointer will be updated from feature/adb-runner to main

/cc @jonathanpeppers

[jonathanpeppers]

All the calls here need to make it to the MSBuild logger, we lost some log messages with this change.

MSBuild tasks have a TaskLoggingHelper Log property, we need to pass this in to android-tools to use it for logging.

We could setup something like this:

https://github.com/dotnet/android-tools/blob/6a6de1f24572d93048f3bbaa997bcfcf43a472dd/src/Microsoft.Android.Build.BaseTasks/MSBuildExtensions.cs#L191-L207

So, from the MSBuild task, it passes in a Action<TraceLevel, string> for dotnet/android-tools to log with.

[rmarinho]

Done — added optional Action<TraceLevel, string>? logger parameters to BuildDeviceDescription and MergeDevicesAndEmulators in android-tools (dotnet/android-tools@9d4b4f5), following the existing CreateTaskLogger pattern from MSBuildExtensions.

Restored debug messages:

• AVD name formatting (original → formatted)
• Running emulator AVD names set
• Skipping already-running emulators
• Added non-running emulators

GetAvailableAndroidDevices now passes this.CreateTaskLogger() to both calls so all messages route through the MSBuild logger.

[jonathanpeppers]

CI fails with:

2026-03-04T15:12:54.1988548Z D:\a\_work\1\s\external\xamarin-android-tools\src\Xamarin.Android.Tools.AndroidSdk\Runners\AdbRunner.cs(139,55): error CS8620: Argument of type 'string?[]' cannot be used for parameter 'args' of type 'string[]' in 'ProcessStartInfo ProcessUtils.CreateProcessStartInfo(string fileName, params string[] args)' due to differences in the nullability of reference types. [D:\a\_work\1\s\external\xamarin-android-tools\src\Xamarin.Android.Tools.AndroidSdk\Xamarin.Android.Tools.AndroidSdk.csproj::TargetFramework=netstandard2.0]
2026-03-04T15:12:54.1989406Z     1 Warning(s)
2026-03-04T15:12:54.1989550Z     3 Error(s)
2026-03-04T15:12:54.1989613Z 
2026-03-04T15:12:54.1989758Z Time Elapsed 00:10:16.48