Skip to content

Add new-pipeline.yml file#4069

Open
paulmedynski wants to merge 2 commits intomainfrom
dev/paul/new-pipeline
Open

Add new-pipeline.yml file#4069
paulmedynski wants to merge 2 commits intomainfrom
dev/paul/new-pipeline

Conversation

@paulmedynski
Copy link
Contributor

Description

This PR adds a new-pipeline.yml file to enable creation of pipelines in the Azure DevOps Public project. Currently, it isn't possible to create a pipeline against this repo unless the top-level YAML file is present in the main branch, which it won't be for pipelines that are still in development.

Testing

No testing required.

@paulmedynski paulmedynski added this to the 7.1.0-preview1 milestone Mar 20, 2026
@paulmedynski paulmedynski requested a review from a team as a code owner March 20, 2026 11:29
@paulmedynski paulmedynski added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label Mar 20, 2026
Copilot AI review requested due to automatic review settings March 20, 2026 11:29
@github-project-automation github-project-automation bot moved this to To triage in SqlClient Board Mar 20, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a placeholder pipeline YAML file under eng/pipelines/ so Azure DevOps Public project pipelines can be created against this repo even before the “real” pipeline YAML exists on main, and updates PR pipeline path filters to ignore changes to this placeholder.

Changes:

  • Added eng/pipelines/new-pipeline.yml placeholder YAML file intended for ADO pipeline creation/bootstrap.
  • Updated both PR validation pipeline definitions to exclude eng/pipelines/new-pipeline.yml from PR path-based triggering.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
eng/pipelines/sqlclient-pr-project-ref-pipeline.yml Excludes eng/pipelines/new-pipeline.yml from PR trigger path filters to avoid validation runs on placeholder-only changes.
eng/pipelines/sqlclient-pr-package-ref-pipeline.yml Same exclusion as above for the package-reference PR pipeline.
eng/pipelines/new-pipeline.yml Introduces a placeholder pipeline YAML file (currently comments-only).

@paulmedynski paulmedynski moved this from To triage to In review in SqlClient Board Mar 20, 2026
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.61%. Comparing base (07a9280) to head (8b74c13).

❗ There is a different number of reports uploaded between BASE (07a9280) and HEAD (8b74c13). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (07a9280) HEAD (8b74c13)
CI-SqlClient 2 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4069      +/-   ##
==========================================
- Coverage   75.17%   65.61%   -9.57%     
==========================================
  Files         280      275       -5     
  Lines       43830    65825   +21995     
==========================================
+ Hits        32951    43193   +10242     
- Misses      10879    22632   +11753     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 65.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get this change. ADO requires the yaml file for the pipeline to exist before you can create the pipeline, that's true, but making a placeholder doesn't make sense to me. If you're working on a new pipeline, just go ahead an make the yaml file with that name.

@github-project-automation github-project-automation bot moved this from In review to In progress in SqlClient Board Mar 20, 2026
@paulmedynski
Copy link
Contributor Author

paulmedynski commented Mar 20, 2026

When creating a new pipeline in Azure DevOps, our projects/org require use of the 1ES Start Right wizard. The first thing we're asked is: Where is the repo? If the repo is in Azure DevOps, and you want to use an existing YAML file, you can choose any branch in the repo, find your file, and happy times. If the repo is in GitHub, the YAML file must already exist on the default branch - you can't select a dev branch. This file will allow us to create a new pipeline against GitHub, point it to this dummy file on main, and then run the pipeline against a dev branch where this dummy file has been replaced (temporarily) with the brand-new pipeline we want to test.

For example, #3867 is creating a new stress test pipeline, but I can't try running it yet becasue I can't create the pipeline in Azure DevOps. If new-pipeline.yml already existed on main, I could symlink it to the new stress-test-pipeline.yml file in this PR, create the pipeline in Azure DevOps, and test run it against this PR branch as part of the PR process. Instead, I have to merge this PR to main without ever having executed it, create the Azure DevOps pipeline, run it, find some inevitable problems, and then open a subsequent PR to fix things.

@David-Engel
Copy link
Contributor

Ask Start Right to fix it. There's a "Make a suggestion" item in the upper right context menu. Then have us all upvote it. 😄

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems.

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

4 participants