chore: Separate solution file for sample projects#3043
Closed
filzrev wants to merge 1 commit intodotnet:masterfrom
Closed
chore: Separate solution file for sample projects#3043filzrev wants to merge 1 commit intodotnet:masterfrom
filzrev wants to merge 1 commit intodotnet:masterfrom
Conversation
Collaborator
|
I'd rather this be done in the same PR as MTP migration if necessary. It seems pointless by itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains following changes.
samples/BenchmarkDotNet.Samples.slnxsolution file instead.launchSettings.jsonsettings.Background
Currently VS TestAdapter and test projects both using VSTest based dependencies.
When replacing TestAdapter to use MTP(Microsoft.Testing.Platform) based implementation (#2803)
Both VSTest/MTP based projects are mixed and it seems Test Explorer unstable state.
And
dotnet testfailed when both VSTest/MTP based project mixed in solution.So it need to separate solution files until TestAdapter/Tests are migrated to use MTP.