Open
Conversation
Collaborator
maycon-mello
commented
Apr 16, 2026
maycon-mello
commented
- improve error handlers for cloud wallet
maycon-mello
force-pushed
the
dcka-5447-wallet-sync-issues
branch
from
eb76cb0 to
5b15eb9
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets wallet/cloud sync reliability by adding/adjusting logging and error handling in the core message fetch flow and EDV document pull flow.
Changes:
- Fixes an object-literal formatting issue in the shared logger transport.
- Adds an explicit error log when message fetching fails.
- Wraps cloud-wallet EDV document pulling in a try/catch with error logging and a fallback return.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/data-store/src/logger.ts |
Adjusts logger transport object formatting (trailing comma). |
packages/core/src/message-provider.ts |
Adds error logging on fetchMessages failure. |
packages/core/src/cloud-wallet.ts |
Adds try/catch and logging around pullDocuments, changes failure behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mike-parkhill
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.