Polish tether gesture compass fades and guide visibility#63
Merged
Conversation
- Extract MobileGestureConfirmation type alias - Derive squareDirectionVector from existing unit vectors - Replace 'east'|'west' string side with 1|-1 sign - Drop dead hasPointerCapture prechecks - Collapse two grid-cols-4 key rows into single grid Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Catch drift if a new gesture input is added without a matching key sequence. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The local variable shadowed the lib helper with the same name; rename to currentDisplayPoint to read clearly at the SVG line. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Extract activeRootDirection and activeTickDirection as helpers over an ActiveGestureState alias; the call sites now read one identifier instead of a 4-deep ternary chain or IIFE. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replace four nested direction/optionIndex branches in rootOptionLayout with a ROOT_CARDINAL_SECONDARY lookup keyed by direction and option. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The hardcoded { x: 195, y: 220 } was a story-specific value leaking into
the lib; the only caller passes its own origin explicitly.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The multi-schedule pattern is mandated by mobile-ui.md §11 because Wall defers xterm focus via rAF; without the repeats a single blur can be reverted after we return. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Drop dead 'above'/'below' ChipPlacement variants, fold translatedStyle into translatedChipStyle, replace duplicated translatedCurrentPoint with the existing translatedPoint, and switch the chip-spawn className to clsx for consistency. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Spec that primary mouse/trackpad clicks (alongside touches and pen presses) open the radial menu so /tether is usable on desktop without a touchscreen, and clarify that non-primary buttons remain unhandled. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Deploying mouseterm with
|
| Latest commit: |
13af502
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f90dd832.mouseterm.pages.dev |
| Branch Preview URL: | https://codex-mobileui-compassrose.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
mobile-gesture-menuunit tests passed.mouseterm-libproduction build passed.