chore: [DSM-95] Clean up task_queue_compatibility_test, part 2#9641
Open
alin-at-dfinity wants to merge 1 commit intomasterfrom
Open
chore: [DSM-95] Clean up task_queue_compatibility_test, part 2#9641alin-at-dfinity wants to merge 1 commit intomasterfrom
task_queue_compatibility_test, part 2#9641alin-at-dfinity wants to merge 1 commit intomasterfrom
Conversation
Clean up the forward compatibility hack in `task_queue_compatibility_test::deserialize()` to stop force setting `next_callback_id` on read (as the old test implementation was not updating it).
Contributor
Author
|
This fails CI for now, but will pass as soon as the NNS is upgraded to replica version |
alin-at-dfinity
changed the title
task_queue_compatibility_test, part 2task_queue_compatibility_test, part 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up the forward compatibility hack in
task_queue_compatibility_test::deserialize()to stop force settingnext_callback_idon read (as the old test implementation was not updating it).