Skip to content

feat: CON-1677 Add user attributes to query calls#9627

Merged
eichhorl merged 4 commits intomasterfrom
eichhorl/query-user-attributes
Mar 30, 2026
Merged

feat: CON-1677 Add user attributes to query calls#9627
eichhorl merged 4 commits intomasterfrom
eichhorl/query-user-attributes

Conversation

@eichhorl
Copy link
Copy Markdown
Contributor

@eichhorl eichhorl commented Mar 27, 2026

Interface spec PR: dfinity/portal#6202

Similar to the previous PR adding user attributes to update calls #9582, this PR does the same for query calls. Both message types make use of the same validation function, which currently rejects messages containing any sender info:

fn validate_sender_info<C: HttpRequestContent>(
request: &HttpRequest<C>,
) -> Result<(), RequestValidationError> {
if request.sender_info().is_some() {
Err(SenderInfoUnsupported)
} else {
Ok(())
}
}
Therefore, as with update calls, any query containing a sender_info field set to Some(_) value is still rejected for now.

Note that currently, the new sender_info field doesn't affect the query cache. Assuming setting sender_info were allowed, this means that sending the same query a second time, but with different sender_info, would lead to a cache hit. This should likely be changed in a follow-up.

@eichhorl eichhorl added the CI_ALL_BAZEL_TARGETS Runs all bazel targets label Mar 27, 2026
@eichhorl eichhorl removed the CI_ALL_BAZEL_TARGETS Runs all bazel targets label Mar 30, 2026
@eichhorl eichhorl changed the title Draft: Add user attributes to queries feat: CON-1677 Add user attributes to query calls Mar 30, 2026
@github-actions github-actions bot added the feat label Mar 30, 2026
@eichhorl eichhorl marked this pull request as ready for review March 30, 2026 08:57
@eichhorl eichhorl requested review from a team as code owners March 30, 2026 08:58
Copy link
Copy Markdown
Contributor

@mraszyk mraszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that currently, the new sender_info field doesn't affect the query cache.

Could you please create a jira ticket so that this information is not lost?

@eichhorl
Copy link
Copy Markdown
Contributor Author

Note that currently, the new sender_info field doesn't affect the query cache.

Could you please create a jira ticket so that this information is not lost?

I saw there is already a ticket here: https://dfinity.atlassian.net/browse/DSM-119

@eichhorl eichhorl added this pull request to the merge queue Mar 30, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 30, 2026
@eichhorl eichhorl added this pull request to the merge queue Mar 30, 2026
Merged via the queue into master with commit 63abe2b Mar 30, 2026
45 of 54 checks passed
@eichhorl eichhorl deleted the eichhorl/query-user-attributes branch March 30, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants