feat: CON-1677 Add user attributes to query calls#9627
Merged
Conversation
mraszyk
approved these changes
Mar 30, 2026
Contributor
mraszyk
left a comment
There was a problem hiding this comment.
Note that currently, the new sender_info field doesn't affect the query cache.
Could you please create a jira ticket so that this information is not lost?
basvandijk
approved these changes
Mar 30, 2026
Contributor
Author
I saw there is already a ticket here: https://dfinity.atlassian.net/browse/DSM-119 |
blind-oracle
approved these changes
Mar 30, 2026
fspreiss
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interface spec PR: dfinity/portal#6202
Similar to the previous PR adding user attributes to update calls #9582, this PR does the same for query calls. Both message types make use of the same validation function, which currently rejects messages containing any sender info:
ic/rs/validator/src/ingress_validation.rs
Lines 429 to 437 in 1e55617
sender_infofield set toSome(_)value is still rejected for now.Note that currently, the new
sender_infofield doesn't affect the query cache. Assuming settingsender_infowere allowed, this means that sending the same query a second time, but with differentsender_info, would lead to a cache hit. This should likely be changed in a follow-up.