feat(governance): New proposal type: CreateCanisterAndInstallCode.#9611
Conversation
…possibly in a non-NNS subnet. No actual impl yet. That's next (sson)...
…erSettings et. al.
…ernance side. Calling Root's create_canister_and_install_code method has been stubbed out. Root's method will be implemented next...
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
This is behind a flag, which per usual, is off in production.
This includes changes to .did, .proto, as well as actual executable implementation, including validation.
Prior Work
This new proposal type overlaps a bit with the existing NnsCanisterInstall proposal type. This differs in a couple of key ways:
Implementation
This is a direct proposal action. This is because we implement validation (which would require Decode if this were instead done as an
NnsFunction).This follows the usual pattern of adding a new
.rsfile to theproposalsdir, dedicated to the new proposal type. Within that file we have variousimplblocks related including ones for various traits.Calls a new method of the Root canister, aptly named
create_canister_and_install_code. See "References". As usual, Root does the real work.Un-nested
CanisterSettingsfrom withinUpdateCanisterSettingsso that it can be shared withCreateCanisterAndInstallCode.A large chunk of the changes here are mechanical type conversions.
Testing
Not yet tested, but since this is behind a flag, it should be fine for this code to be deployed (and in the master branch).
References
👈 Previous PR