fix(ckbtc): prevent double-mint of cached UTXOs after transaction finalization#9596
Open
gregorydemay wants to merge 5 commits intomasterfrom
Open
fix(ckbtc): prevent double-mint of cached UTXOs after transaction finalization#9596gregorydemay wants to merge 5 commits intomasterfrom
gregorydemay wants to merge 5 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_utxoscache after their transaction has been finalized and forgotten by the minterminted_outpointsbefore check/mint to deduplicate already-minted outpointsdeduplicated_outpointsstate field with ackbtc_minter_deduplicated_outpoint_countmetric for observabilityshould_not_mint_cached_utxo) that reproduces the full scenario: mint → submit tx → cache fill → finalize tx → update_balance with stale cache🤖 Generated with Claude Code