feat(delegations): [CON-1664] make cloud engine nodes use API BNs to fetch delegations#9595
Draft
pierugo-dfinity wants to merge 40 commits intomasterfrom
Draft
feat(delegations): [CON-1664] make cloud engine nodes use API BNs to fetch delegations#9595pierugo-dfinity wants to merge 40 commits intomasterfrom
pierugo-dfinity wants to merge 40 commits intomasterfrom
Conversation
…nto pierugo/delegations/type4-adjustments
…legations/type4-adjustments
This reverts commit c3121df.
pierugo-dfinity
commented
Mar 30, 2026
| ) | ||
| "#; | ||
|
|
||
| const INSTALLED_CANISTER_IDS: &str = "installed_canister_ids"; |
Contributor
Author
There was a problem hiding this comment.
Before this PR, we would only install a canister in the application subnet and assumed that its ID would be the node's effective canister ID (i.e. the first ID in the subnet's canister range). This is true if this is the first installed canister but breaks when we install a canister on the NNS subnet since the latter already has some installed canisters. We thus keep track of the canister IDs between the setup and test phases through a file in the test environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since non-cloud engine nodes (including nodes of the NNS subnet) deny incoming connections from cloud engine nodes in the firewall, a few adjustments are required.
Cloud engines' registry replicators already use API BNs instead of NNS nodes directly. Similarly, this PR makes cloud engine nodes use API BNs instead of NNS nodes to fetch delegations.
This PR also extends the current system test on NNS delegations to test all endpoints on all subnet types (including the NNS, which should effectively not return a delegation).
Note: this PR is currently blocked by #9613 which provisions DNS records for API BN domains as well as valid TLS certificates inside the system test environment. Thus, all system tests currently using cloud engines fail but will pass once #9613 and #9609 are merged. The current state of the PR is available for review despite the tests failing.
Another note: even when #9613 is merged, we would have to wait that it reaches mainnet NNS before re-enabling the mainnet variant of the system test for cloud engines. This is tracked in CON-1696.