Fix rule_id displaying as wrong number on GitHub for rules 0100–0135#409
Merged
Merged
Conversation
rule_id values like 0100 were being parsed as octal integers by YAML 1.1 (0100 octal = 64 decimal), causing a mismatch with the filename. Quoting the values ensures they are treated as strings. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dennisdoomen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Rules with IDs between 0100 and 0135 display the wrong
rule_idvalue when viewed on GitHub. For example,0100.mdshowsrule_id: 64instead of0100.This happens because YAML 1.1 (used by Jekyll) interprets unquoted numbers with a leading zero as octal. So
0100(octal) =64(decimal).Fix
Quote the
rule_idvalues in the 9 affected files so YAML treats them as strings: