Prioritize common functions in the value position#1669
Prioritize common functions in the value position#1669rolandwalker wants to merge 1 commit intomainfrom
Conversation
No direct security issues found in this diff. |
The bot makes a good point! The half-implementation of case-folding is too much incomplete. |
de44d39 to
2875c7b
Compare
Like favorite_keywords, add a list of favorite_functions which should be ordered ahead when completing function names in the value position. Currently the only real effect this has is to suggest JSON_VALUE() ahead of JSON_VALID(), resolving a small common annoyance. But we should further curate the list of favorites. Another longstanding idea is to have dynamic frecency govern the list of favorites. There happened to be a test case for JSON_VALUE/JSON_VALID already.
2875c7b to
97a6ed3
Compare
Description
Like
favorite_keywords, add a list offavorite_functionswhich should be ordered ahead when completing function names in the value position.Currently the only real effect this has is to suggest
JSON_VALUE()ahead ofJSON_VALID(), resolving a small common annoyance. But we should further curate the list of favorites.Another longstanding idea is to have dynamic frecency govern the list of favorites.
There happened to be a test case for
JSON_VALUE/JSON_VALIDalready.Since MySQL styles some functions as title case, we incidentally start to make some allowances for that here, but it doesn't yet show up in the UI. Ideally it would.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).