You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Missing regression test for the exact bug fixed (medium)
The PR changes iteration to for warning_token in list(style.keys()) in mycli/clistyle.py:189, which prevents mutating a dict during iteration. There is no corresponding test to lock this behavior.
Action: add a unit test for style_factory_helpers(..., warnings=True) that asserts it does not raise and that Token.Output.* entries are created from Token.Warnings.*.
Current style tests don’t protect this path (medium)
Existing tests in test/test_clistyle.py are skipped, so this fix is currently unguarded by active tests.
Action: add/enable a non-skipped test for style_factory_helpers (not only style_factory_toolkit) covering warnings-style token copying.
Security concerns found in this PR: none.
I couldn’t execute tests in this environment (pytest and required deps are unavailable), so runtime verification here is limited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in #1653.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).