feat: implement device authentication (no browser)#105
Merged
Conversation
Collaborator
Author
|
TODO: I think I need to revert the staging client id for zitadel when the official one will be correctly configured |
Contributor
|
@gianarb does the new client ID support both device code and PKCE authentication? We may need to select which client to use based on the |
Collaborator
Author
|
It does not, I thought somehow you could have clients with both method
enabled at the same time. If not yep we need to do the switch on code.
Let me add it
…On Wed Feb 18, 2026 at 1:06 AM CET, Scot Schuchert-Wells wrote:
scotwells left a comment (datum-cloud/datumctl#105)
@gianarb does the new client ID support both device code and PKCE authentication? We may need to select which client to use based on the `--no-browser` flag.
|
We need a way to authentication the datumctl even when a browser is not available. For example inside a container or in a server. OAuth cover this scenario with device authentication. Zitadel supports device auth and it is documented here: https://zitadel.com/docs/guides/integrate/login/oidc/device-authorization This commit implements this flow when `--no-browser` is passed to `datumctl auth login`
gianarb
force-pushed
the
feat/device-auth
branch
from
12090fa to
209d881
Compare
scotwells
previously approved these changes
Mar 30, 2026
scotwells
reviewed
Mar 30, 2026
internal/cmd/auth/login.go
Outdated
Comment on lines
+28
to
+31
| stagingClientID = "325848904128073754" // Client ID for staging | ||
| stagingClientID = "360304563007327549" // Client ID for staging |
Contributor
There was a problem hiding this comment.
@gianarb let's leave this client ID in place. I'll adjust the existing auth clients to support the device code flow.
Contributor
There was a problem hiding this comment.
The staging / production clients were updated to include the device code grant type.
scotwells
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need a way to authentication the datumctl even when a browser is not
available. For example inside a container or in a server.
OAuth cover this scenario with device authentication.
Zitadel supports device auth and it is documented here:
https://zitadel.com/docs/guides/integrate/login/oidc/device-authorization
This commit implements this flow when
--no-browseris passed todatumctl auth loginFixed #104