chore: add timestamp in logging#1084
Open
maudetes wants to merge 1 commit into
Open
Conversation
maudetes
requested review from
ThibaudDauce and
nicolaskempf57
and removed request for
ThibaudDauce
ThibaudDauce
approved these changes
May 20, 2026
| let __logger_plugin_initialized = false | ||
|
|
||
| export default defineNuxtPlugin(() => { | ||
| if (process.env.NODE_ENV === 'production' && !__logger_plugin_initialized) { |
Contributor
There was a problem hiding this comment.
I prefer early returns for this kind of stuff but not mandatory:
Suggested change
| if (process.env.NODE_ENV === 'production' && !__logger_plugin_initialized) { | |
| if (__logger_plugin_initialized) return | |
| if (process.env.NODE_ENV !== 'production') return |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of datagouv/data.gouv.fr#2015
We don't currently have any timestamp in logging, this PR prefix logs with a timestamp.
To raise an error, go to: http://dev.local:3000/users/does-not-exist
I think this solution is ugly, but at the moment I did not find a good approach that don't require adding an extra dependency.
Any other better idea?