fix: add missing comma in whitelist.py causing /mcp* routes to be unw…#925
Open
llanc wants to merge 1 commit intodataease:mainfrom
Open
fix: add missing comma in whitelist.py causing /mcp* routes to be unw…#925llanc wants to merge 1 commit intodataease:mainfrom
llanc wants to merge 1 commit intodataease:mainfrom
Conversation
…hitelisted "*.css.map" was missing a trailing comma, causing Python's implicit string literal concatenation to merge it with the next entry into "*.css.map/mcp*". This made the /mcp* whitelist rule never match, so all /mcp/* endpoints (mcp_start, mcp_question, mcp_get_sql, mcp_execute_sql, etc.) were blocked by TokenMiddleware with "Miss Token[X-SQLBOT-TOKEN]" even though they are intended to handle their own authentication internally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hitelisted
".css.map" was missing a trailing comma, causing Python's implicit string literal concatenation to merge it with the next entry into ".css.map/mcp*". This made the /mcp* whitelist rule never match, so all /mcp/* endpoints were blocked by TokenMiddleware with "Miss Token[X-SQLBOT-TOKEN]" even though they are intended to handle their own authentication internally.