Skip to content

Security: Potential Sensitive Information Exposure in Logging #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Security: Potential Sensitive Information Exposure in Logging #804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/databricks/sql/experimental/oauth_persistence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,13 @@ def read(self, hostname: str) -> Optional[OAuthToken]:

# Note this is only intended to be used for development
class DevOnlyFilePersistence(OAuthPersistence):
if not os.environ.get('ENVIRONMENT') == 'dev':
logger.warning('DevOnlyFilePersistence is not intended for production use.')
def __init__(self, file_path):
self._file_path = file_path

def persist(self, hostname: str, token: OAuthToken):
logger.info(f"persisting token in {self._file_path}")
logger.debug(f"persisting token in {self._file_path}")

# Data to be written
dictionary = {
Expand Down