[DLPack] Update to include DLPack C Exchange API#984
[DLPack] Update to include DLPack C Exchange API#984tqchen wants to merge 5 commits intodata-apis:mainfrom
Conversation
This PR updates to include dlpack C exchange api for fast exchange at c-extension level without going through python.
|
Respective dlpack PR on python spec dmlc/dlpack#180 |
|
Implements #973 |
rgommers
left a comment
There was a problem hiding this comment.
Thanks @tqchen! I refreshed my memory here, I think this PR largely looks good and we're probably ready to put this in. My main question right now is: given it's been in use in PyTorch for a couple of months now, do you have any real-world experience to share so far? No issues, did it help a lot performance-wise, etc.
|
thanks @rgommers , updated to address your reviews. In terms of the current state, it has been merged into PyTorch and used through some of the tvm-ffi integrations through paddle and other env. So far no issues identified and it does help reducing host overhead in the specific case of tvm-ffi |
|
We touched on this PR in the community meeting yesterday. The general feeling was that it's time to merge this. @seberg and @leofang may want to have another look. I plan to merge this at the end of next week unless there are more concerns. The feeling in the meeting is that it would be better if this new C API in DLPack would be a complete replacement for the |
This PR updates to include dlpack C exchange api for fast exchange at c-extension level without going through python.