Skip to content

chore(ci): drop no-std CI jobs#522

Open
ZocoLini wants to merge 1 commit intov0.42-devfrom
chore/drop-nostd-ci
Open

chore(ci): drop no-std CI jobs#522
ZocoLini wants to merge 1 commit intov0.42-devfrom
chore/drop-nostd-ci

Conversation

@ZocoLini
Copy link
Collaborator

@ZocoLini ZocoLini commented Mar 12, 2026

I dont know if i am forgetting something or i am removing more than what I should

Summary by CodeRabbit

  • Chores
    • Removed no-std build verification from CI pipeline. No-std support is no longer maintained as part of the standard build checks.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 26ee06da-8f79-4f58-bbbc-0df11fe433bc

📥 Commits

Reviewing files that changed from the base of the PR and between 33cefc9 and eb82d49.

📒 Files selected for processing (2)
  • .github/ci-no-std.yml
  • .github/scripts/ci_config.py
💤 Files with no reviewable changes (2)
  • .github/ci-no-std.yml
  • .github/scripts/ci_config.py

📝 Walkthrough

Walkthrough

The pull request removes no-std build verification support from the project's continuous integration pipeline. This includes deleting the dedicated no-std configuration file and removing the associated Python script logic, CLI arguments, and command mappings that handled no-std build checks.

Changes

Cohort / File(s) Summary
No-std CI Support Removal
.github/ci-no-std.yml, .github/scripts/ci_config.py
Deleted the no-std CI configuration file and removed the run_no_std() function, --no-std-file CLI argument, run-no-std subcommand, and its command dispatch mapping from the CI configuration script.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 No-std checks hop away,
The CI pipeline grows lean today,
Features fade with a gentle touch,
Simplicity we love so much!
One less path to maintain and test.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(ci): drop no-std CI jobs' accurately and concisely describes the main change: removing no-std CI configuration and related scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/drop-nostd-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.90%. Comparing base (33cefc9) to head (eb82d49).

Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #522      +/-   ##
=============================================
- Coverage      66.90%   66.90%   -0.01%     
=============================================
  Files            313      313              
  Lines          64757    64757              
=============================================
- Hits           43325    43324       -1     
- Misses         21432    21433       +1     
Flag Coverage Δ *Carryforward flag
core 74.93% <ø> (ø)
dash-network 74.91% <ø> (ø) Carriedforward from 33cefc9
dash-network-ffi 34.76% <ø> (ø) Carriedforward from 33cefc9
dash-spv 68.26% <ø> (ø) Carriedforward from 33cefc9
dash-spv-ffi 34.76% <ø> (ø) Carriedforward from 33cefc9
dashcore 74.91% <ø> (ø) Carriedforward from 33cefc9
dashcore-private 74.91% <ø> (ø) Carriedforward from 33cefc9
dashcore-rpc 19.92% <ø> (ø) Carriedforward from 33cefc9
dashcore-rpc-json 19.92% <ø> (ø) Carriedforward from 33cefc9
dashcore_hashes 74.91% <ø> (ø) Carriedforward from 33cefc9
ffi 36.38% <ø> (-0.02%) ⬇️
key-wallet 65.65% <ø> (ø) Carriedforward from 33cefc9
key-wallet-ffi 34.76% <ø> (ø) Carriedforward from 33cefc9
key-wallet-manager 65.65% <ø> (ø) Carriedforward from 33cefc9
rpc 19.92% <ø> (ø)
spv 81.11% <ø> (+<0.01%) ⬆️
wallet 65.68% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant