chore(release): update changelog and bump version to 3.1.0-dev.6#3746
Conversation
|
Warning Review limit reached
More reviews will be available in 18 minutes and 55 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR increments the workspace and package versions from ChangesRelease 3.1.0-dev.6
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ash-sdk, wallet-lib These three NPM packages have their own major version lines (4.x, 6.x, 10.x) that move in lockstep with the platform-wide -dev.N suffix. bump_version.js with --target-version=3.1.0-dev.6 calls setExactVersion which overwrites every package version, so they were incorrectly squashed to 3.1.0-dev.6. Restore to 4.1.0-dev.6 / 6.1.0-dev.6 / 10.1.0-dev.6 to match the dev.5 → dev.6 step on their own lines.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 1: The changelog header for "3.1.0-dev.6" contains malformed links (e.g.,
"///compare/v3.1.0-dev.5...v3.1.0-dev.6" and any
"undefined/undefined/undefined/issues/..." occurrences); update the
"3.1.0-dev.6" section so all URLs are fully qualified GitHub links consistent
with the other entries (use the same base GitHub URL pattern used later in the
file), replacing the broken compare link and any undefined issue/PR links for
the 3.1.0-dev.6 entry.
In `@packages/dash-spv/package.json`:
- Line 3: The package version for `@dashevo/dash-spv` has been changed from
4.1.0-dev.5 to 3.1.0-dev.6, causing a major-version rollback; revert the version
change in packages/dash-spv/package.json so the "version" field for
`@dashevo/dash-spv` continues on the 4.1.0-dev.x track (e.g., bump to 4.1.0-dev.6
or keep 4.1.0-dev.5 if intentional) and ensure any related changelogs or release
metadata referencing `@dashevo/dash-spv` are updated to match the restored
4.1.x-dev versioning.
In `@packages/wallet-lib/package.json`:
- Line 3: The package.json "version" field currently reads "3.1.0-dev.6" which
appears to be a major-version regression from the prior "10.1.0-dev.5"; restore
the intended major version by updating the "version" value in
packages/wallet-lib/package.json to the correct sequence (e.g., "10.1.0-dev.6")
or provide a commit message/CHANGELOG entry explaining and approving an
intentional reset; specifically edit the "version" property to the expected
semver string (replace "3.1.0-dev.6" with "10.1.0-dev.6" or the correct target)
and ensure CI/publishing metadata aligns with that change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6ea48640-e7d1-4087-9344-278088e1716c
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (25)
CHANGELOG.mdCargo.tomlpackage.jsonpackages/bench-suite/package.jsonpackages/dapi-grpc/package.jsonpackages/dapi/package.jsonpackages/dash-spv/package.jsonpackages/dashmate/package.jsonpackages/dashpay-contract/package.jsonpackages/dpns-contract/package.jsonpackages/js-dapi-client/package.jsonpackages/js-dash-sdk/package.jsonpackages/js-evo-sdk/package.jsonpackages/js-grpc-common/package.jsonpackages/keyword-search-contract/package.jsonpackages/masternode-reward-shares-contract/package.jsonpackages/platform-test-suite/package.jsonpackages/token-history-contract/package.jsonpackages/wallet-lib/package.jsonpackages/wallet-utils-contract/package.jsonpackages/wasm-dpp/package.jsonpackages/wasm-dpp2/package.jsonpackages/wasm-drive-verify/package.jsonpackages/wasm-sdk/package.jsonpackages/withdrawals-contract/package.json
conventional-changelog could not derive the repo host because the root package.json has no "repository" field and the fork's origin was used as the fallback, producing "///compare/" and "undefined/undefined/undefined/issues/N" links. Replace with the canonical https://github.com/dashpay/platform URLs to match dev.5's format.
All four lines (one chore + three tests) came from dashpay#3679 but were merged via a merge commit instead of squash, so each underlying commit produced its own changelog entry. Collapse into a single chore line linking to the PR.
thepastaclaw
left a comment
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
All three version-downgrade findings (dash-spv, dash, wallet-lib) and the malformed CHANGELOG links are confirmed against the source. Both agents independently flagged the same blocking issues. The release script clearly ran in a degraded state — package versions were reset onto the platform's 3.x track instead of advancing each package's independent major line, and the changelog template was unable to resolve the repo URL.
🔴 3 blocking | 🟡 1 suggestion(s)
Out-of-scope follow-up suggestions (2)
These are valid observations, but they are outside this PR's scope and should be handled in separate issues or author/maintainer-requested PRs rather than blocking this review.
- Harden release script so missing repo URL fails fast — The
undefined/undefined/undefined/...placeholders and///compare/...header indicate the changelog generator (semantic-release / standard-version) could not resolverepository.urlduring this run. Until that environmental/tooling regression is fixed, every future release will silently ship broken links. This is wider than the current PR's scope (a routine version bump) and should be tracked separately.- Follow-up: Open a separate issue to audit the release workflow config so a missing repo URL aborts the release job instead of producing malformed changelog entries.
- Decide and document version policy for dash-spv / dash / wallet-lib — These three npm packages have been on independent major version tracks (4.x, 6.x, 10.x) for a long time. If the project intends to unify them under the platform version going forward, that needs an explicit decision, a deprecation note for consumers of the existing majors, and a dedicated PR — not a side-effect of a dev bump.
- Follow-up: Open a separate issue/PR to formalize the versioning policy for these npm packages, with migration notes for consumers on the existing major lines.
thepastaclaw
left a comment
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Prior finding reconciliation for f777173: dash-spv/js-dash-sdk/wallet-lib version downgrades are FIXED by the latest delta; the malformed CHANGELOG compare/issue links are STILL VALID and carried forward. New latest-delta findings: none verified.
Three prior blocking version-downgrade findings are confirmed FIXED at f777173 — dash-spv is 4.1.0-dev.6, dash is 6.1.0-dev.6, wallet-lib is 10.1.0-dev.6. The CHANGELOG malformed-links finding is STILL VALID: the 3.1.0-dev.6 entry header still uses ///compare/... and PR references still use undefined/undefined/undefined/issues/..., while older entries use fully-qualified GitHub URLs. No new code, consensus, or security issues introduced by this release-only PR.
🟡 1 suggestion(s)
Out-of-scope follow-up suggestions (1)
These are valid observations, but they are outside this PR's scope and should be handled in separate issues or author/maintainer-requested PRs rather than blocking this review.
- Fix release tooling: repository URL resolution and per-package major version tracking — Two release-tool defects show up in this PR: (1) the changelog generator emitted
///compare/...andundefined/undefined/undefined/issues/...URLs, indicating the repository URL is not resolved when rendering the changelog; (2) a corrective follow-up commit (f777173) was required to re-apply per-package majors (4.x/6.x/10.x) after the standardreleasescript unified everything at 3.1.0-dev.6. Both point at gaps in the release config rather than anything authored in this PR.- Follow-up: Open a separate issue/PR to fix the release-tool configuration (repository URL injection and per-package version tracking) so future
chore(release)PRs don't require manual changelog and version patches.
- Follow-up: Open a separate issue/PR to fix the release-tool configuration (repository URL injection and per-package version tracking) so future
Review details
🤖 Prompt for all review comments with AI agents
These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.
In `CHANGELOG.md`:
- [SUGGESTION] lines 1-25: New 3.1.0-dev.6 changelog entry has malformed compare and issue links
The 3.1.0-dev.6 section at the top of CHANGELOG.md uses `///compare/v3.1.0-dev.5...v3.1.0-dev.6` for the release header (line 1) and `undefined/undefined/undefined/issues/<n>` for every PR reference (lines 6–9, 14–20, 25), while every prior section (e.g. line 35 for 3.1.0-dev.5) uses fully-qualified `https://github.com/dashpay/platform/...` URLs. The release tool failed to resolve the repository URL when generating this entry, so the new section's links will not navigate on GitHub or in downstream changelog renderers. Regenerate this section with the repository URL configured, or hand-patch the header and all `undefined/undefined/undefined/issues/...` references to `https://github.com/dashpay/platform/issues/...` before tagging.
Reviewed commit: f7771737
| ## [3.1.0-dev.6](///compare/v3.1.0-dev.5...v3.1.0-dev.6) (2026-05-26) | ||
|
|
||
|
|
||
| ### Features | ||
|
|
||
| * **platform-wallet:** expose sync_watermark() on PlatformAddressWallet ([#3723](undefined/undefined/undefined/issues/3723)) | ||
| * **platform-wallet:** IdentityManager::identity_ids + FFI no-selectable-inputs error mapping ([#3651](undefined/undefined/undefined/issues/3651)) | ||
| * **platform-wallet:** serde support ([#3637](undefined/undefined/undefined/issues/3637)) | ||
| * **swift-sdk,platform-wallet:** wire shielded send end-to-end (all 4 transitions) ([#3603](undefined/undefined/undefined/issues/3603)) | ||
|
|
||
|
|
||
| ### Bug Fixes | ||
|
|
||
| * **drive-abci:** bill batch transformer drive reads ([#3670](undefined/undefined/undefined/issues/3670)) | ||
| * **drive-abci:** correct DECRYPTION bounds branch + bill grovedb reads in bounds validation ([#3697](undefined/undefined/undefined/issues/3697)) | ||
| * **platform-wallet:** fail-closed on registration persist error (Found-017) [backport] ([#3659](undefined/undefined/undefined/issues/3659)) | ||
| * **platform-wallet:** spv client deadlocking when sending a tx ([#3730](undefined/undefined/undefined/issues/3730)) | ||
| * **sdk:** forward wasm grpc-web trailers to tonic ([#3726](undefined/undefined/undefined/issues/3726)) | ||
| * **sdk:** sdk emits incompatible getDocuments wire against pre-v3.1 networks (QueryContext approach) ([#3711](undefined/undefined/undefined/issues/3711)) | ||
| * **wasm-sdk:** support binary grove path elements ([#3657](undefined/undefined/undefined/issues/3657)) | ||
|
|
||
|
|
||
| ### Miscellaneous Chores | ||
|
|
||
| * bump rust-dashcore to rev f569e7b7b99dfe589c41f9ba7d36fbbe6805acdc ([#3729](undefined/undefined/undefined/issues/3729)) |
There was a problem hiding this comment.
🟡 Suggestion: New 3.1.0-dev.6 changelog entry has malformed compare and issue links
The 3.1.0-dev.6 section at the top of CHANGELOG.md uses ///compare/v3.1.0-dev.5...v3.1.0-dev.6 for the release header (line 1) and undefined/undefined/undefined/issues/<n> for every PR reference (lines 6–9, 14–20, 25), while every prior section (e.g. line 35 for 3.1.0-dev.5) uses fully-qualified https://github.com/dashpay/platform/... URLs. The release tool failed to resolve the repository URL when generating this entry, so the new section's links will not navigate on GitHub or in downstream changelog renderers. Regenerate this section with the repository URL configured, or hand-patch the header and all undefined/undefined/undefined/issues/... references to https://github.com/dashpay/platform/issues/... before tagging.
source: ['claude', 'codex']
thepastaclaw
left a comment
thepastaclaw
left a comment
There was a problem hiding this comment.
Code Review
Prior finding reconciliation for 6025e57: malformed CHANGELOG compare/issue links are FIXED. New latest-delta findings: none verified unless listed below.
Release PR bumping workspace version to 3.1.0-dev.6 with CHANGELOG.md updates. Latest delta (c268a46, 6025e57) repaired the malformed compare/issue URLs flagged previously and consolidated PR #3679 changelog entries. Prior finding changelog-malformed-links is FIXED. No new in-scope issues.
Out-of-scope follow-up suggestions (1)
These are valid observations, but they are outside this PR's scope and should be handled in separate issues or author/maintainer-requested PRs rather than blocking this review.
- Release tooling appears to require manual post-processing of CHANGELOG.md — Commit c268a46 hand-patched
///compare/...andundefined/undefined/undefined/issues/<n>placeholders in both the new 3.1.0-dev.6 section and older 3.0.1 / 3.0.1-hotfix.3 / 3.0.1-hotfix.4 entries, and commit 6025e57 manually consolidated four generator-emitted entries for PR #3679. This suggests the standard-version / conventional-changelog config in this repo cannot resolve the upstream repository URL when generating the changelog. Unrelated to this PR's release goal but worth fixing so futurechore(release)PRs don't need hand-patching.- Follow-up: Open a separate issue to fix the release/changelog tooling (likely a missing
repository.urlor--presetconfiguration) so future release PRs produce correct URLs and consolidated entries without manual edits.
- Follow-up: Open a separate issue to fix the release/changelog tooling (likely a missing
Reviewed commit: 6025e570
2 participants
Issue being fixed or feature implemented
Release new Dash Platform version
What was done?
How Has This Been Tested?
None
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit