Remove no-op DANDI_ALLOW_LOCALHOST_URLS from test configs#1829
Merged
yarikoptic merged 1 commit intodandi:masterfrom Apr 2, 2026
Merged
Remove no-op DANDI_ALLOW_LOCALHOST_URLS from test configs#1829yarikoptic merged 1 commit intodandi:masterfrom
DANDI_ALLOW_LOCALHOST_URLS from test configs#1829yarikoptic merged 1 commit intodandi:masterfrom
Conversation
This variable was consumed by the dandi-archive Django server to permit `localhost` URLs in asset `contentUrl` fields during testing (where assets are stored in a local MinIO instance). It was removed from the test `docker-compose.yml` in commit 09c1b75 when dandi-archive switched to `dandiapi.settings.development`, which handles this by default, making the variable a no-op in the test environment. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
candleindark
added
internal
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1829 +/- ##
==========================================
- Coverage 75.13% 75.12% -0.01%
==========================================
Files 84 84
Lines 11931 11931
==========================================
- Hits 8964 8963 -1
- Misses 2967 2968 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yarikoptic
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DANDI_ALLOW_LOCALHOST_URLSwas consumed by the dandi-archive Djangoserver to permit
localhostURLs in assetcontentUrlfields duringtesting (where assets are stored in a local MinIO instance).
docker-compose.ymlin commit 09c1b75when dandi-archive switched to
dandiapi.settings.development, whichallows localhost URLs by default — making this variable a no-op.
tox.iniand.github/workflows/run-tests.yml.Test plan
docker-compose.yml(removed in 09c1b75)🤖 Generated with Claude Code