Apply #2507 bounds checks to RandomGenerator():random() and :irandom()#2863
Open
oznogon wants to merge 2 commits intodaid:masterfrom
Open
Apply #2507 bounds checks to RandomGenerator():random() and :irandom()#2863oznogon wants to merge 2 commits intodaid:masterfrom
oznogon wants to merge 2 commits intodaid:masterfrom
Conversation
Contributor
|
the reason: I forgot RandomGenerator got added and the scenarios I was checking either didn't use it or used it correctly 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2507 added standalone
random()andirandom()Lua global functions with bounds checks, but didn't add bounds checks toRandomGenerator():random()andRandomGenerator():irandom().Align
RandomGenerator()behavior to the standalone functions'.Not sure if there was a reason for this omission, cc @GinjaNinja32