Skip to content

Make manifest modals share the same viewer#891

Open
autochamchikim-pixel wants to merge 3 commits into
cyclops-ui:mainfrom
autochamchikim-pixel:main
Open

Make manifest modals share the same viewer#891
autochamchikim-pixel wants to merge 3 commits into
cyclops-ui:mainfrom
autochamchikim-pixel:main

Conversation

@autochamchikim-pixel
Copy link
Copy Markdown

closes #641

Description

  • add a shared manifest viewer component for the Ace editor, copy button, theme, and loading state
  • use the shared viewer for module, rendered, and resource manifest modals
  • add loadingResourceManifest while fetching resource manifests and remove the default OK footer from manifest modals

Checks

  • npx --yes prettier@3.2.5 --check src/components/shared/ManifestContent/ManifestContent.tsx src/components/shared/ModuleResourceDetails/ModuleResourceDetails.tsx src/components/k8s-resources/ResourceList/ResourceList.tsx
  • npx --yes esbuild@0.24.0 src/components/shared/ManifestContent/ManifestContent.tsx src/components/shared/ModuleResourceDetails/ModuleResourceDetails.tsx src/components/k8s-resources/ResourceList/ResourceList.tsx --loader:.tsx=tsx --format=esm --outdir=../../evidence/esbuild-check --log-level=warning
  • .\node_modules.bin\react-scripts.cmd build (compiled; existing source-map warnings from @microsoft/fetch-event-source)

@autochamchikim-pixel autochamchikim-pixel requested a review from a team as a code owner May 27, 2026 05:32
@autochamchikim-pixel
Copy link
Copy Markdown
Author

@quest-bot loot #641

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manifests modals to use the same theme

1 participant