DM fixes (detailed log & webhook)#837
Open
dmamelin wants to merge 2 commits intocustom-components:masterfrom
Open
DM fixes (detailed log & webhook)#837dmamelin wants to merge 2 commits intocustom-components:masterfrom
dmamelin wants to merge 2 commits intocustom-components:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #836, I noticed a difference in the
@webhook_triggerimplementation and aligned it with the legacy behavior.In #834, this is definitely a bug in user code, but I also noticed that the exception message lacks useful detail.
While porting DM to the new error-handling subsystem, I introduced a bug - exceptions raised inside triggered functions become uninformative.
@craigbarratt, please release a hotfix.