[IS-10713] draft implementation for language selector feature for SSP#63
[IS-10713] draft implementation for language selector feature for SSP#63vahag-curity wants to merge 1 commit intomainfrom
Conversation
| TODO: the language selector should be extracted to its own component in @curity/ui-kit-component-library, | ||
| as it is a separate concern from the user menu and it will make the Header component cleaner and more readable. | ||
| */} | ||
| <div className="relative" ref={menuContainerRef}> |
There was a problem hiding this comment.
@urre I suggest extracting this into its own LanguageSelector component
perhaps better to use
<select>
<option value="sv"></option>
...
</select>
so, it is easier to extract the value of the selected option
WDYT?
There was a problem hiding this comment.
It's an option. Another option is to reuse <UserMenu> and making that multi-purpose.
But <select> also works fine, simple and easy. We could also nest it inside the <UserMenu> See this example:
| TODO: this should be moved to @curity/ui-kit-css | ||
| to be used by UserMenu and the new language selector component | ||
| */ | ||
| .user-menu { |
There was a problem hiding this comment.
@urre could we extract this into css lib and reuse it both for user menu and language selector components?
There was a problem hiding this comment.
Yea. I don't think we should add all this CSS. We already have the <UserMenu> from our component library src/common/component-library/src/components/user-menu/UserMenu.tsx
We can generalize this in to a DropdownMenu component and reuse for both UserMenu and LanguageSelector
There was a problem hiding this comment.
Or use <Select> like the other comment
3 participants
No description provided.