fix: listen to user:offline event to individually mark viewers offline#3457
Open
servusrene wants to merge 1 commit intocrowbartools:v5from
Open
fix: listen to user:offline event to individually mark viewers offline#3457servusrene wants to merge 1 commit intocrowbartools:v5from
servusrene wants to merge 1 commit intocrowbartools:v5from
Conversation
The ActiveUserHandler emits "user:offline" when a viewers online cache TTL expires (7.5 min without activity), but no listener existed for this event. This meant viewers were never individually marked offline in the ViewerDB - only bulk-cleared on chat disconnect or stream end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
The ActiveUserHandler emits "user:offline" when a viewer's online cache TTL expires (7.5 min without activity), but no listener existed for this event. This meant viewers were never individually marked offline in the ViewerDB — only bulk-cleared on chat disconnect or stream end.
Applicable Issues
#3455
Testing