fix(tools): use LF line endings in generate_tool_specs.py to prevent CRLF diffs on Windows#4979
Open
NIK-TIGER-BILL wants to merge 1 commit intocrewAIInc:mainfrom
Open
Conversation
Python's open() in text mode uses OS-native line endings. On Windows this produces CRLF, making every line in tool.specs.json appear changed in git diff even when no logical content changed. Fix: pass newline="\n" to open() so the output always uses LF, matching the committed file and eliminating spurious diffs. Closes crewAIInc#4737
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, Python's
open()in text mode writes CRLF line endings. This causesgenerate_tool_specs.pyto regeneratetool.specs.jsonwith\r\n, making every line appear modified ingit diffeven when no content changed.Fix: add
newline="\n"to theopen()call insave_to_json()to force LF output on all platforms.Closes #4737