update the transform regex to account for image format transform too#591
Open
i-just wants to merge 1 commit into
Open
update the transform regex to account for image format transform too#591i-just wants to merge 1 commit into
i-just wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The transform subfolder is always based on the transform string, but if the transform also changes the filename (e.g., the image format), the subfolder is based on the asset ID as well. For example:
/_toWebp/100C.webp/_toWebp/123/100C.webpThe code: https://github.com/craftcms/cms/blob/5.10.2/src/imagetransforms/ImageTransformer.php#L316-L325.
When you select an image to insert into a CKEditor field (image mode: tags) and choose a transform in the modal, we check whether the URL is transformed and matches the first pattern, but not the second.
This PR updates the regex used to check whether the URL is for a transformed asset to account for the asset ID potentially appearing after the transform string.
Related issues
#588