fix(affiliate): replace useWalletInfo chainId usage with useWalletCha…#7230
fix(affiliate): replace useWalletInfo chainId usage with useWalletCha…#7230kernelwhisperer merged 3 commits intodevelopfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
WalkthroughThe affiliate module's chain ID sourcing is refactored across containers, hooks, and page components from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Danziger
left a comment
There was a problem hiding this comment.
Approved, but maybe we should look into this after the fix is merged?
TBH, it's not obvious the difference of behavior between useWalletInfo and useWalletChainId, so I'll try to make the former work like the latter and maybe even get rid of useWalletChainId if there's no need for it after the change.
In any case, because of the upcoming Viem migration, I would just create an issue to look at this later. @kernelwhisperer do you want to take care of it or should I assign it to myself?
I think it's the way it is because the app was "designed" with chainId being a requirement, e.g. disconnected wallet gives you chainId 1 so you can get a quote without a wallet |
Yep, what I suggest is to look into that to see how much work it is to make the hook return |
alfetopito
left a comment
There was a problem hiding this comment.
Works as described.
I share Dani's concerns on the logic, as this is very easy to miss and revert to the previous pattern.
I also agree it's not blocking.
|
LGTM! |
Summary
Fixes the unsupported network logic in affiliate: https://nomevlabs.slack.com/archives/C0361CDG8GP/p1774878380978359
To Test
Summary by CodeRabbit