Skip to content

CBL-8289: Reject replication filter requests on unexpected errors #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pasin merged 1 commit into from
May 13, 2026
Merged

CBL-8289: Reject replication filter requests on unexpected errors #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions common/main/java/com/couchbase/lite/internal/ReplicationCollection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,19 +121,31 @@ static boolean filterCallback(
revID,
collToken,
coll);

// This should never happen. If it does, abort and return false for security reasons.
if (coll == null) {
Log.w(LOG_DOMAIN, "Request to filter unrecognized collection: " + scope + "." + name);
return true;
Log.w(LOG_DOMAIN,
"Rejecting filter request for unrecognized collection %s.%s, returning false",
scope, name);
return false;
}

final C4Filter filter = (isPush) ? coll.c4PushFilter : coll.c4PullFilter;
if (filter == null) { return true; }

// This shouldn't happen.
// If it does, we have no idea what is going on and shouldn't get in the way.
// This should never happen. If it does, abort and return false for security reasons.
if (filter == null) {
Log.w(LOG_DOMAIN,
"Rejecting filter request, %s filter could not be found, returning false",
isPush ? "push" : "pull");
return false;
}

// This should never happen. If it does, abort and return false for security reasons.
if ((docID == null) || (revID == null)) {
Log.w(LOG_DOMAIN, "Ignoring filter request for null %s/%s", docID, revID);
return true;
Log.w(LOG_DOMAIN,
"Rejecting filter request with null docID or revID: %s/%s, returning false",
docID, revID);
return false;
}
Comment thread
pasin marked this conversation as resolved.

final ClientTask<Boolean> task = new ClientTask<>(() -> filter.test(docID, revID, body, flags));
Expand Down
Loading