CBL-8290: Reject replication filter requests on unexpected errors#479
Merged
Conversation
* Changed ReplicationCollection filter callback to return false (reject) rather than true (allow) when encountering unexpected error conditions. * Updated comments and log messages.
|
This is a release branch and commits are restricted. Please confirm this PR is one of the following:
|
Collaborator
Author
|
The change has been approved to correct and sync behavior per the a fix for a customer in .NET. |
There was a problem hiding this comment.
Pull request overview
This PR changes replication filter callback failure handling to fail closed by rejecting filter requests under unexpected error conditions.
Changes:
- Reject unrecognized collection filter callbacks instead of allowing them.
- Reject missing filter callbacks instead of allowing them.
- Reject null document/revision IDs and update warning messages.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
borrrden
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed ReplicationCollection filter callback to return false (reject) rather than true (allow) when encountering unexpected error conditions.
Updated comments and log messages.